[minor] Remove **** in test case names in FlatMapGroupsWithStateSuite#18715
Closed
rxin wants to merge 1 commit intoapache:masterfrom
Closed
[minor] Remove **** in test case names in FlatMapGroupsWithStateSuite#18715rxin wants to merge 1 commit intoapache:masterfrom
rxin wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @tdas Was there a reason to use |
|
Test build #79873 has finished for PR 18715 at commit
|
Member
|
LGTM |
Member
|
Thanks! Merging to master. |
Contributor
Author
|
Wait let's ask why @tdas did it this way...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch removes the
****string from test names in FlatMapGroupsWithStateSuite.***is a common string developers grep for when using Scala test (because it immediately shows the failing test cases). The existence of the****in test names disrupts that workflow.How was this patch tested?
N/A - test only change.